🐛 Fix ember launcher exiting before Testem collects results #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The launcher was hooking into QUnit.done/Mocha end events and immediately calling process.exit(0) when tests completed. This caused "Browser exited unexpectedly" errors because Testem hadn't finished collecting results yet. Testem manages the browser lifecycle itself - it sends SIGTERM when done. The test framework hooks were unnecessary. Changes: - Remove QUnit/Mocha test completion detection - Let Testem control shutdown via signals - Add browser crash/disconnect handlers - Better error logging with stack traces - Use VIZZLY_LOG_LEVEL=debug for debug output (consistent with CLI) - Exit with code 1 on errors (was always 0)
This comment was marked as resolved.
This comment was marked as resolved.
Robdel12
force-pushed
the
fix/ember-testem-launcher-lifecycle
branch
from
ccbf307 to
1cb87ca
Compare
- Await cleanup() in all event handlers to ensure proper resource release - Remove unused cleanupReason variable - Add stack trace to main catch block for consistency
Robdel12
force-pushed
the
fix/ember-testem-launcher-lifecycle
branch
from
1cb87ca to
a25fe0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
VIZZLY_LOG_LEVEL=debugfor debug output (consistent with CLI)Test plan
ember test --filter "url-with-protocol"